Skip to content

Cannot use router.isActive fix #20954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 27, 2025
Merged

Cannot use router.isActive fix #20954

merged 6 commits into from
Aug 27, 2025

Conversation

moulichan99
Copy link
Contributor

Added setupRouter before which initializes _routerMicrolib.

@moulichan99 moulichan99 changed the title Added setupRouter before which initializes _routerMicrolib. isActive fix Jul 28, 2025
@moulichan99 moulichan99 changed the title isActive fix Cannot use router.isActive fix Jul 28, 2025
@NullVoxPopuli
Copy link
Contributor

Thanks for working on this! Excited for the fix!

@moulichan99
Copy link
Contributor Author

@NullVoxPopuli can you please check & let me know ?

NullVoxPopuli
NullVoxPopuli approved these changes Aug 6, 2025
View reviewed changes
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you!

@kategengler kategengler requested a review from wagenet August 6, 2025 04:37
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2025 •
edited
Loading

Estimated Asset Sizes

Diff

--- main/out.txt	2025-08-13 03:31:42.000000000 +0000
+++ pr/./pr-17256182550/out.txt	2025-08-27 03:07:42.000000000 +0000
@@ -1,13 +1,13 @@
-╔═══════╤═══════════╤═══════════╗
-║       │ Min       │ Gzip      ║
-╟───────┼───────────┼───────────╢
-║ Total │ 418.48 KB │ 231.88 KB ║
-╚═══════╧═══════════╧═══════════╝
+╔═══════╤═══════════╤══════════╗
+║       │ Min       │ Gzip     ║
+╟───────┼───────────┼──────────╢
+║ Total │ 418.51 KB │ 231.9 KB ║
+╚═══════╧═══════════╧══════════╝
 
 ╔══════════════════════╤═══════════╤═══════════╗
 ║ @ember/*             │ Min       │ Gzip      ║
 ╟──────────────────────┼───────────┼───────────╢
-║ Total                │ 239.23 KB │ 147.06 KB ║
+║ Total                │ 239.26 KB │ 147.08 KB ║
 ╟──────────────────────┼───────────┼───────────╢
 ║ -internals           │ 35.44 KB  │ 25.49 KB  ║
 ║ application          │ 12.83 KB  │ 7.62 KB   ║
@@ -25,7 +25,7 @@
 ║ object               │ 33.78 KB  │ 20.79 KB  ║
 ║ owner                │ 159 B     │ 178 B     ║
 ║ renderer             │ 385 B     │ 327 B     ║
-║ routing              │ 58.05 KB  │ 33.43 KB  ║
+║ routing              │ 58.08 KB  │ 33.45 KB  ║
 ║ runloop              │ 2.2 KB    │ 1.33 KB   ║
 ║ service              │ 859 B     │ 741 B     ║
 ║ template             │ 430 B     │ 390 B     ║

Details

This PRmain
 
╔═══════╤═══════════╤══════════╗
║       │ Min       │ Gzip     ║
╟───────┼───────────┼──────────╢
║ Total │ 418.51 KB │ 231.9 KB ║
╚═══════╧═══════════╧══════════╝

╔══════════════════════╤═══════════╤═══════════╗
║ @ember/*             │ Min       │ Gzip      ║
╟──────────────────────┼───────────┼───────────╢
║ Total                │ 239.26 KB │ 147.08 KB ║
╟──────────────────────┼───────────┼───────────╢
║ -internals           │ 35.44 KB  │ 25.49 KB  ║
║ application          │ 12.83 KB  │ 7.62 KB   ║
║ array                │ 12.66 KB  │ 7.32 KB   ║
║ canary-features      │ 304 B     │ 419 B     ║
║ component            │ 1.07 KB   │ 1004 B    ║
║ controller           │ 1.8 KB    │ 1.36 KB   ║
║ debug                │ 11.4 KB   │ 7.92 KB   ║
║ deprecated-features  │ 31 B      │ 77 B      ║
║ destroyable          │ 561 B     │ 383 B     ║
║ enumerable           │ 259 B     │ 387 B     ║
║ helper               │ 823 B     │ 570 B     ║
║ instrumentation      │ 2.43 KB   │ 1.78 KB   ║
║ modifier             │ 669 B     │ 614 B     ║
║ object               │ 33.78 KB  │ 20.79 KB  ║
║ owner                │ 159 B     │ 178 B     ║
║ renderer             │ 385 B     │ 327 B     ║
║ routing              │ 58.08 KB  │ 33.45 KB  ║
║ runloop              │ 2.2 KB    │ 1.33 KB   ║
║ service              │ 859 B     │ 741 B     ║
║ template             │ 430 B     │ 390 B     ║
║ template-compilation │ 429 B     │ 366 B     ║
║ template-compiler    │ 57.81 KB  │ 30.3 KB   ║
║ template-factory     │ 94 B      │ 160 B     ║
║ test                 │ 923 B     │ 627 B     ║
║ utils                │ 3.93 KB   │ 3.5 KB    ║
║ version              │ 55 B      │ 131 B     ║
╚══════════════════════╧═══════════╧═══════════╝

╔═════════════════╤═══════════╤══════════╗
║ @glimmer/*      │ Min       │ Gzip     ║
╟─────────────────┼───────────┼──────────╢
║ Total           │ 179.25 KB │ 84.81 KB ║
╟─────────────────┼───────────┼──────────╢
║ destroyable     │ 2.7 KB    │ 1.35 KB  ║
║ encoder         │ 596 B     │ 653 B    ║
║ env             │ 38 B      │ 87 B     ║
║ global-context  │ 886 B     │ 545 B    ║
║ manager         │ 12.19 KB  │ 5.44 KB  ║
║ node            │ 2.71 KB   │ 1.81 KB  ║
║ opcode-compiler │ 29.89 KB  │ 13.23 KB ║
║ owner           │ 159 B     │ 202 B    ║
║ program         │ 7.1 KB    │ 3.63 KB  ║
║ reference       │ 5.51 KB   │ 3.18 KB  ║
║ runtime         │ 95.26 KB  │ 42.51 KB ║
║ tracking        │ 989 B     │ 961 B    ║
║ util            │ 3.03 KB   │ 2.29 KB  ║
║ validator       │ 15.64 KB  │ 6.86 KB  ║
║ vm              │ 784 B     │ 798 B    ║
║ wire-format     │ 1.84 KB   │ 1.35 KB  ║
╚═════════════════╧═══════════╧══════════╝

╔═══════╤═══════════╤═══════════╗
║       │ Min       │ Gzip      ║
╟───────┼───────────┼───────────╢
║ Total │ 418.48 KB │ 231.88 KB ║
╚═══════╧═══════════╧═══════════╝

╔══════════════════════╤═══════════╤═══════════╗
║ @ember/*             │ Min       │ Gzip      ║
╟──────────────────────┼───────────┼───────────╢
║ Total                │ 239.23 KB │ 147.06 KB ║
╟──────────────────────┼───────────┼───────────╢
║ -internals           │ 35.44 KB  │ 25.49 KB  ║
║ application          │ 12.83 KB  │ 7.62 KB   ║
║ array                │ 12.66 KB  │ 7.32 KB   ║
║ canary-features      │ 304 B     │ 419 B     ║
║ component            │ 1.07 KB   │ 1004 B    ║
║ controller           │ 1.8 KB    │ 1.36 KB   ║
║ debug                │ 11.4 KB   │ 7.92 KB   ║
║ deprecated-features  │ 31 B      │ 77 B      ║
║ destroyable          │ 561 B     │ 383 B     ║
║ enumerable           │ 259 B     │ 387 B     ║
║ helper               │ 823 B     │ 570 B     ║
║ instrumentation      │ 2.43 KB   │ 1.78 KB   ║
║ modifier             │ 669 B     │ 614 B     ║
║ object               │ 33.78 KB  │ 20.79 KB  ║
║ owner                │ 159 B     │ 178 B     ║
║ renderer             │ 385 B     │ 327 B     ║
║ routing              │ 58.05 KB  │ 33.43 KB  ║
║ runloop              │ 2.2 KB    │ 1.33 KB   ║
║ service              │ 859 B     │ 741 B     ║
║ template             │ 430 B     │ 390 B     ║
║ template-compilation │ 429 B     │ 366 B     ║
║ template-compiler    │ 57.81 KB  │ 30.3 KB   ║
║ template-factory     │ 94 B      │ 160 B     ║
║ test                 │ 923 B     │ 627 B     ║
║ utils                │ 3.93 KB   │ 3.5 KB    ║
║ version              │ 55 B      │ 131 B     ║
╚══════════════════════╧═══════════╧═══════════╝

╔═════════════════╤═══════════╤══════════╗
║ @glimmer/*      │ Min       │ Gzip     ║
╟─────────────────┼───────────┼──────────╢
║ Total           │ 179.25 KB │ 84.81 KB ║
╟─────────────────┼───────────┼──────────╢
║ destroyable     │ 2.7 KB    │ 1.35 KB  ║
║ encoder         │ 596 B     │ 653 B    ║
║ env             │ 38 B      │ 87 B     ║
║ global-context  │ 886 B     │ 545 B    ║
║ manager         │ 12.19 KB  │ 5.44 KB  ║
║ node            │ 2.71 KB   │ 1.81 KB  ║
║ opcode-compiler │ 29.89 KB  │ 13.23 KB ║
║ owner           │ 159 B     │ 202 B    ║
║ program         │ 7.1 KB    │ 3.63 KB  ║
║ reference       │ 5.51 KB   │ 3.18 KB  ║
║ runtime         │ 95.26 KB  │ 42.51 KB ║
║ tracking        │ 989 B     │ 961 B    ║
║ util            │ 3.03 KB   │ 2.29 KB  ║
║ validator       │ 15.64 KB  │ 6.86 KB  ║
║ vm              │ 784 B     │ 798 B    ║
║ wire-format     │ 1.84 KB   │ 1.35 KB  ║
╚═════════════════╧═══════════╧══════════╝

@moulichan99
Copy link
Contributor Author

Lgtm, thank you!

How much time it takes to merge ?

@wagenet
Copy link
Member

wagenet commented Aug 12, 2025

@moulichan99 Sorry for the delay! It looks like this fails linting.

@moulichan99
Copy link
Contributor Author

moulichan99 commented Aug 23, 2025 •
edited
Loading

@moulichan99 Sorry for the delay! It looks like this fails linting.

Will check. Thanks for the update

@moulichan99
Copy link
Contributor Author

@wagenet can we rerun this workflows ?

@moulichan99
Copy link
Contributor Author

@wagenet can we rerun this workflows ?

cc: @NullVoxPopuli @kategengler

@NullVoxPopuli
Copy link
Contributor

I don't have the ability. I'll bother some folks on discord

@wagenet
Copy link
Member

wagenet commented Aug 25, 2025

The workflows did re-run and they still failed.

@kategengler
Copy link
Member

@wagenet Can you review for content? We'll figure out the linting.

wagenet
wagenet approved these changes Aug 27, 2025
View reviewed changes
Copy link
Member

@wagenet wagenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Thanks!

@kategengler kategengler merged commit 7f11a35 into emberjs:main Aug 27, 2025
29 checks passed
@kategengler kategengler mentioned this pull request Aug 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wagenet wagenet wagenet approved these changes

@kategengler kategengler Awaiting requested review from kategengler

+1 more reviewer

@NullVoxPopuli NullVoxPopuli NullVoxPopuli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@kategengler kategengler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@moulichan99 @NullVoxPopuli @wagenet @kategengler